Read the findings of the 2022 Web3 Security Report

In the contract `ModuleRegistry` the role `_owner` has authority over the functions shown in the diagram below.

Any compromise to the `_owner` account may allow the hacker to take advantage of this authority.

![](https://accelerator-tasks-prod.s3.amazonaws.com/806bc6287f4c4770bf93fb37d7a74c4c/diagrams/centralization-ModuleRegistry-_owner.svg)

In the contract `SecurityModule` the role `_owner` has authority over the functions shown in the diagram below.

Any compromise to the `_owner` account may allow the hacker to take advantage of this authority.

![](https://accelerator-tasks-prod.s3.amazonaws.com/806bc6287f4c4770bf93fb37d7a74c4c/diagrams/centralization-SecurityModule-_owner.svg)

In the contract `TransactionModule` the role `_owner` has authority over the functions shown in the diagram below.

Any compromise to the `_owner` account may allow the hacker to take advantage of this authority.

![](https://accelerator-tasks-prod.s3.amazonaws.com/806bc6287f4c4770bf93fb37d7a74c4c/diagrams/centralization-TransactionModule-_owner.svg)

In the contract `Wallet` the role `_owner` has authority over the functions shown in the diagram below.

Any compromise to the `_owner` account may allow the hacker to take advantage of this authority.

![](https://accelerator-tasks-prod.s3.amazonaws.com/806bc6287f4c4770bf93fb37d7a74c4c/diagrams/centralization-Wallet-_owner.svg)

Centralization Risks

This protocol provides the wallet which allows the user:
- Use multi-signature
- Recover the owner by social recovery
- Lockable
- Payment Limitation

But there are some issues needed to discuss:
1. What is the contract `Forwarder` used for?
2. What is the `_sequenceId`? what is the `_sequenceId` used for?
3. The comments say that transactions over the limit require multiple signatures, but we don't see how this is accomplished in the code.

Financial Models

The function did not check whether the `wallets` array had already contained the `_wallet`. However, it can be inferred from `removeWallet()` and `isRegisteredWallet()` that every element in the `wallets` array shouldn't have a duplicate.

Missing Duplicate Check

There should always be events emitted in the sensitive functions that are controlled by centralization roles.

Missing Emit Events

File: projects/EigenNetwork/contracts/SecurityModule.sol (Line 309-313, Function `SecurityModule.splitSignature`)
```solidity
assembly {
  r := mload(add(_signatures, add(0x20,mul(0x41,_index))))
  s := mload(add(_signatures, add(0x40,mul(0x41,_index))))
  v := and(mload(add(_signatures, add(0x41,mul(0x41,_index)))), 0xff)
}
```

---
File: projects/EigenNetwork/contracts/Wallet.sol (Line 180-183, Function `Wallet.invoke`)
```solidity
assembly {
  returndatacopy(0, 0, returndatasize())
  revert(0, returndatasize())
}
```

---
File: projects/EigenNetwork/contracts/Wallet.sol (Line 195-198, Function `Wallet.raw_invoke`)
```solidity
assembly {
  returndatacopy(0, 0, returndatasize())
  revert(0, returndatasize())
}
```

Assembly Usage

The fallback function can only rely on 2300 gas being available (for example when sending or transfer is used), token transfer in the fallback function will cost more than 2300 gas and more extra gas is required. Is that designed as expected? (https://docs.soliditylang.org/en/v0.5.8/contracts.html#fallback-function)

Potential Out-of-Gas Exception

It will be confusing if the modifier just revert directly without providing error message.

Missing Error Messages

The `addModule` calls the `IWallet(_wallet).authoriseModule()`. The `IWallet(_wallet).authoriseModule()` needs the `owner` authority but the `SecurityModule` is not the owner. So the `authoriseModule()` will be reverted.

Function never worked

If the owner uses the function `authoriseModule()` to cancel the authorization of the module, the module can never be authorized again. Because the `module.init()` need the `_wallet` was never registered but the authorization before had already registered the `_wallet`.

Authorization Issue

Eigen Network

TransactionModule.sol

ModuleRegistry.sol

SecurityModule.sol

ForwarderTarget.sol

Forwarder.sol

Eigen Network

Highlights & Alerts

This is just a placeholder

highlight placeholder lorem Ipsum...

highlight lorem

This is a alert demo

Alert demo

Code Audit History

9

0

1

1

7