Read the findings of the 2022 Web3 Security Report

The contract has unlocked compiler version. An unlocked compiler version in the source code of the contract permits the user to compile it at or above a particular version. This, in turn, leads to differences in the generated bytecode between compilations due to differing compiler version numbers. This can lead to an ambiguity when debugging as compiler specific bugs may occur in the codebase that would be hard to identify over a span of multiple compiler versions rather than a specific one.

Unlocked Compiler Version

`_price` is defined by the user as below, the user can borrow as much token as he wants, in fact, `_price` should be fixed appropriately by the contract.

```solidity
    function queryNFTPriceCB(bytes32 _requestId, uint256 _price)

`_price` Defined Externally

In the function `liquidation`, `repayAmount` tokens did not transfer to the contract during the creation of the auction. 

```solidity
    uint repayAmount = this.calcRent(borrowId, info.liquidateTime);

    // operator is the first bidder
    auctionMap[borrowId] = Auction({
        endTime: block.timestamp + 24 hours,
        bidder: payable(_msgSender()),
        startTime: block.timestamp,
        borrowId: borrowId,
        amount: repayAmount,
        settled: false
    });


Borrowings Not Repaid In Liquidation

A reentrancy attack can occur when the contract creates a function that makes an external call to another untrusted contract before resolving any effects. If the attacker can control the untrusted contract, they can make a recursive call back to the original function, repeating interactions that would have otherwise not run after the external call resolved the effects.

File: projects/hasai/contracts/Hasai.sol (Line 165-169, Function `Hasai.queryNFTPriceCB`)

File: projects/hasai/contracts/Hasai.sol (Line 231, Function `Hasai.repay`)


Potential Reentrancy Attack

In the contract `Hasai` the role `_owner` has authority over the functions shown as below.
Any compromise to the `_owner` account may allow the hacker to take advantage of this authority and modify the contract configurations.

Line 119, Function `Hasai.removeCollectionMap`

Line 124, Function `Hasai.pause`

Line 128, Function `Hasai.unpause`

Line 240, Function `Hasai.withdrawETH`

Line 314, Function `Hasai.withdrawERC20`

Line 320, Function `Hasai.withdrawNFT`

---

In the contract `Hasai` the role `MANAGE_ROLE` has authority over the functions shown as below.
Any compromise to the `MANAGE_ROLE` account may allow the hacker to take advantage of this authority and modify the contract configurations.

Line 89, Function `Hasai.updateMinBorrowTime`

Line 93, Function `Hasai.updateCollectionMap`

Line 115, Function `Hasai.updatePriceOracle`



Centralization Risks in Hasai.sol

The return value of the transfer()/transferFrom() call is not checked.

File: projects/hasai/contracts/Hasai.sol (Line 335, Function `Hasai._safeTransferETHWithFallback`)
```solidity
    IERC20Upgradeable(WETH).transfer(to, amount);
```



Unchecked ERC-20 `transfer()`/`transferFrom()` Call

The return value of an external call is not stored in a local or state variable.

File: projects/hasai/contracts/Hasai.sol (Line 112, Function `Hasai.updateCollectionMap`)
```solidity
    supportNFT.add(_nft);
```


---
File: projects/hasai/contracts/Hasai.sol (Line 121, Function `Hasai.removeCollectionMap`)
```solidity
    supportNFT.remove(_nft);
```


---
File: projects/hasai/contracts/Hasai.sol (Line 182, Function `Hasai.queryNFTPriceCB`)
```solidity
    userBorrowIdMap[info.user].add(borrowId);
```


---
File: projects/hasai/contracts/Hasai.sol (Line 229, Function `Hasai.repay`)
```solidity
    userBorrowIdMap[_msgSender()].remove(borrowId);
```


---
File: projects/hasai/contracts/Hasai.sol (Line 258, Function `Hasai.liquidation`)
```solidity
    userBorrowIdMap[info.user].remove(borrowId);
```


---
File: projects/hasai/contracts/Hasai.sol (Line 272, Function `Hasai.liquidation`)
```solidity
    auctions.add(borrowId);
```


---
File: projects/hasai/contracts/Hasai.sol (Line 307, Function `Hasai.claimBidNFT`)
```solidity
    auctions.remove(borrowId);
```


---
File: projects/hasai/contracts/Hasai.sol (Line 327, Function `Hasai.withdrawNFT`)
```solidity
    userBorrowIdMap[info.user].remove(borrowId);
```



Unused Return Value

Addresses should be checked before assignment or external call to make sure they are not zero addresses.

File: projects/hasai/contracts/Hasai.sol (Line 116, Function `Hasai.updatePriceOracle`)
```solidity
    priceOracle = _oracle;
```
- `_oracle` is not zero-checked before being used.


---
File: projects/hasai/contracts/Hasai.sol (Line 52, Function `Hasai.initialize`)
```solidity
    WETH = _weth;
```
- `_weth` is not zero-checked before being used.


---
File: projects/hasai/contracts/Hasai.sol (Line 53, Function `Hasai.initialize`)
```solidity
    priceOracle = _oracle;
```
- `_oracle` is not zero-checked before being used.



Missing Zero Address Validation

The functions which are never called internally within the contract should have external visibility for gas optimization.

File: projects/hasai/contracts/Hasai.sol (Line 155, Contract `Hasai`)
```solidity
    function queryNFTPriceCB(bytes32 _requestId, uint256 _price)
```


---
File: projects/hasai/contracts/Hasai.sol (Line 48, Contract `Hasai`)
```solidity
    function initialize(
```


Function Should Be Declared External

There should always be events emitted in the sensitive functions that are controlled by centralization roles.

Missing Emit Events

Hasai

Configuration.sol

Hasai

Highlights & Alerts

This is just a placeholder

highlight placeholder lorem Ipsum...

highlight lorem

This is a alert demo

Alert demo

Code Audit History

10

0

2

1

7