Read the findings of the 2022 Web3 Security Report

The `RobocockUWU` Protocol is a decentralized finance(Defi) token deployed on the BSC. The buy/sell transactions will be charged fees. If at least one of sender and recipient is exclude from fee, the fees will be removed. The fee is sent to the `Tax_Address` after transaction. The owner can set the buy/sell fee rates.

Financial Models

In the contract `GKen` the role `_owner` has authority over the functions shown in the diagram below.
Any compromise to the `_owner` account may allow the hacker to take advantage of this authority and change the configuration of this contract.
![](https://accelerator-tasks-prod.s3.amazonaws.com/219f5419ed9b4328a9ad63b4ffd1cd09/diagrams/centralization_GKen__owner.svg)

In the contract `GKenERC20` the role `_owner` has authority over the functions shown in the diagram below.
Any compromise to the `_owner` account may allow the hacker to take advantage of this authority and change the configuration of this contract.
![](https://accelerator-tasks-prod.s3.amazonaws.com/219f5419ed9b4328a9ad63b4ffd1cd09/diagrams/centralization_GKenERC20__owner.svg)

In the contract `Migrations` the role `owner` has authority over the functions shown in the diagram below.
Any compromise to the `owner` account may allow the hacker to take advantage of this authority and change the configuration of this contract.
![](https://accelerator-tasks-prod.s3.amazonaws.com/219f5419ed9b4328a9ad63b4ffd1cd09/diagrams/centralization_Migrations_owner.svg)

In the contract `Ownable` the role `_owner` has authority over the functions shown in the diagram below.
Any compromise to the `_owner` account may allow the hacker to take advantage of this authority and change the configuration of this contract.
![](https://accelerator-tasks-prod.s3.amazonaws.com/219f5419ed9b4328a9ad63b4ffd1cd09/diagrams/centralization_Ownable__owner.svg)

Centralization Risks

There should always be events emitted in the sensitive functions that are controlled by centralization roles.

Missing Emit Events

The linked statements do not affect the functionality of the codebase and appear to be either leftovers from test code or older functionality.

Redundant Code Components

One or more declarations do not conform to the [Solidity style guide](https://solidity.readthedocs.io/en/v0.7.3/style-guide.html#naming-conventions) with regards to its naming convention.

Particularly:
- `camelCase`: Should be applied to function names, argument names, local and state variable names, modifiers
- `UPPER_CASE`: Should be applied to `constant` variables
- `CapWords`: Should be applied to contract names, struct names, event names and enums

File: GKen.sol (Line 22, Contract `GKen`)
```solidity
    address public PRESALE_ADDRESS = 0x708ef6E756240af2397D5Cecb6C3066DAA67A5d7;
```
- Variable `PRESALE_ADDRESS` is not in `camelCase`.


---
File: GKen.sol (Line 23, Contract `GKen`)
```solidity
    address public LP_ADDRESS = 0xc5B2Fc2E11d2008339812f8cE94513f10B4327BC;
```
- Variable `LP_ADDRESS` is not in `camelCase`.


---
File: GKen.sol (Line 24, Contract `GKen`)
```solidity
    address public MARKETING_ADDRESS = 0xc450827d10368c2dC0c922deE4A65dBbCD3C4905;
```
- Variable `MARKETING_ADDRESS` is not in `camelCase`.


---
File: GKen.sol (Line 25, Contract `GKen`)
```solidity
    address public PARTNERS_ADVISORS_ADDRESS = 0x70d673345DD4Ff8CC8a77d7b77732a7BBC756a21;
```
- Variable `PARTNERS_ADVISORS_ADDRESS` is not in `camelCase`.


---
File: GKen.sol (Line 26, Contract `GKen`)
```solidity
    address public DEV_ADDRESS = 0x4A38F7b351B093536c9C527B08fF1d3508C1A76d;
```
- Variable `DEV_ADDRESS` is not in `camelCase`.


---
File: GKen.sol (Line 27, Contract `GKen`)
```solidity
    address public PRIVATESALE_ADDRESS = 0xB178dA6F5FBa03732568374f5c1402d4B5E48955;
```
- Variable `PRIVATESALE_ADDRESS` is not in `camelCase`.


---
File: GKen.sol (Line 28, Contract `GKen`)
```solidity
    address public REWARD_POOL_ADDRESS = 0xF8848562B41b031E625755455d00CAE3f942c8F5;
```
- Variable `REWARD_POOL_ADDRESS` is not in `camelCase`.


---
File: GKen.sol (Line 30, Contract `GKen`)
```solidity
    address public TAX_ADDRESS = 0x5F700413656931cc17205FBb89f33c72410D7105;
```
- Variable `TAX_ADDRESS` is not in `camelCase`.


---
File: GKenERC20.sol (Line 34, Function `GKenERC20.setTransferFeeRate`)
```solidity
    function setTransferFeeRate(uint256 _sellFeeRate, uint256 _buyFeeRate ) public onlyOwner {
```
- Parameter `_buyFeeRate` is not in `camelCase`.


---
File: GKenERC20.sol (Line 34, Function `GKenERC20.setTransferFeeRate`)
```solidity
    function setTransferFeeRate(uint256 _sellFeeRate, uint256 _buyFeeRate ) public onlyOwner {
```
- Parameter `_sellFeeRate` is not in `camelCase`.


---
File: Migrations.sol (Line 6, Contract `Migrations`)
```solidity
  uint public last_completed_migration;
```
- Variable `last_completed_migration` is not in `camelCase`.


---
File: UniSwap.sol (Line 32, Contract `IUniswapV2Pair`)
```solidity
  function DOMAIN_SEPARATOR() external view returns (bytes32);
```
- Function `DOMAIN_SEPARATOR` is not in `camelCase`.


---
File: UniSwap.sol (Line 33, Contract `IUniswapV2Pair`)
```solidity
  function PERMIT_TYPEHASH() external pure returns (bytes32);
```
- Function `PERMIT_TYPEHASH` is not in `camelCase`.


---
File: UniSwap.sol (Line 50, Contract `IUniswapV2Pair`)
```solidity
  function MINIMUM_LIQUIDITY() external pure returns (uint);
```
- Function `MINIMUM_LIQUIDITY` is not in `camelCase`.


---
File: UniSwap.sol (Line 68, Contract `IUniswapV2Router01`)
```solidity
  function WETH() external pure returns (address);
```
- Function `WETH` is not in `camelCase`.



Declaration Naming Convention

The functions which are never called internally within the contract should have external visibility for gas optimization.

File: ERC20.sol (Line 100, Contract `ERC20`)
```solidity
    function balanceOf(address account) public view virtual override returns (uint256) {
```


---
File: ERC20.sol (Line 112, Contract `ERC20`)
```solidity
    function transfer(address recipient, uint256 amount) public virtual override returns (bool) {
```


---
File: ERC20.sol (Line 120, Contract `ERC20`)
```solidity
    function allowance(address owner, address spender) public view virtual override returns (uint256) {
```


---
File: ERC20.sol (Line 131, Contract `ERC20`)
```solidity
    function approve(address spender, uint256 amount) public virtual override returns (bool) {
```


---
File: ERC20.sol (Line 149, Contract `ERC20`)
```solidity
    function transferFrom(
```


---
File: ERC20.sol (Line 177, Contract `ERC20`)
```solidity
    function increaseAllowance(address spender, uint256 addedValue) public virtual returns (bool) {
```


---
File: ERC20.sol (Line 196, Contract `ERC20`)
```solidity
    function decreaseAllowance(address spender, uint256 subtractedValue) public virtual returns (bool) {
```


---
File: ERC20.sol (Line 61, Contract `ERC20`)
```solidity
    function name() public view virtual override returns (string memory) {
```


---
File: ERC20.sol (Line 69, Contract `ERC20`)
```solidity
    function symbol() public view virtual override returns (string memory) {
```


---
File: ERC20.sol (Line 93, Contract `ERC20`)
```solidity
    function totalSupply() public view virtual override returns (uint256) {
```


---
File: GKen.sol (Line 127, Contract `GKen`)
```solidity
    function excludeMultipleAccountsFromFees(address[] calldata accounts, bool excluded) public onlyOwner {
```


---
File: GKen.sol (Line 135, Contract `GKen`)
```solidity
    function isExcludedFromFees(address account) public view returns(bool) {
```


---
File: GKenERC20.sol (Line 25, Contract `GKenERC20`)
```solidity
    function pause() public onlyOwner {
```


---
File: GKenERC20.sol (Line 29, Contract `GKenERC20`)
```solidity
    function unpause() public onlyOwner {
```


---
File: GKenERC20.sol (Line 34, Contract `GKenERC20`)
```solidity
    function setTransferFeeRate(uint256 _sellFeeRate, uint256 _buyFeeRate ) public onlyOwner {
```


---
File: Migrations.sol (Line 16, Contract `Migrations`)
```solidity
    function setCompleted(uint completed) public restricted {
```


---
File: Ownable.sol (Line 53, Contract `Ownable`)
```solidity
    function renounceOwnership() public virtual onlyOwner {
```


---
File: Ownable.sol (Line 61, Contract `Ownable`)
```solidity
    function transferOwnership(address newOwner) public virtual onlyOwner {
```



Function Should Be Declared External

A local variable is shadowing another component defined elsewhere.

File: GKen.sol (Line 33, Function `GKen.constructor`)
```solidity
    string memory name,
```
- Local variable `name` shadows:
    - Function `name` in `ERC20`
    - Function `name` in `IERC20Metadata`

File: ERC20.sol (Line 61, Contract `ERC20`)
```solidity
    function name() public view virtual override returns (string memory) {
```

File: IERC20Metadata.sol (Line 16, Contract `IERC20Metadata`)
```solidity
    function name() external view returns (string memory);
```


---
File: GKen.sol (Line 34, Function `GKen.constructor`)
```solidity
    string memory symbol,
```
- Local variable `symbol` shadows:
    - Function `symbol` in `ERC20`
    - Function `symbol` in `IERC20Metadata`

File: ERC20.sol (Line 69, Contract `ERC20`)
```solidity
    function symbol() public view virtual override returns (string memory) {
```

File: IERC20Metadata.sol (Line 21, Contract `IERC20Metadata`)
```solidity
    function symbol() external view returns (string memory);
```


---
File: GKen.sol (Line 39, Function `GKen.constructor`)
```solidity
    uint256 totalSupply = 10 ** 9 * decimal ;
```
- Local variable `totalSupply` shadows:
    - Function `totalSupply` in `ERC20`
    - Function `totalSupply` in `IERC20`

File: ERC20.sol (Line 93, Contract `ERC20`)
```solidity
    function totalSupply() public view virtual override returns (uint256) {
```

File: IERC20.sol (Line 12, Contract `IERC20`)
```solidity
    function totalSupply() external view returns (uint256);
```


---
File: GKenERC20.sol (Line 21, Function `GKenERC20.constructor`)
```solidity
    constructor(string memory name, string memory symbol) ERC20(name, symbol) {
```
- Local variable `name` shadows:
    - Function `name` in `ERC20`
    - Function `name` in `IERC20Metadata`

File: ERC20.sol (Line 61, Contract `ERC20`)
```solidity
    function name() public view virtual override returns (string memory) {
```

File: IERC20Metadata.sol (Line 16, Contract `IERC20Metadata`)
```solidity
    function name() external view returns (string memory);
```


---
File: GKenERC20.sol (Line 21, Function `GKenERC20.constructor`)
```solidity
    constructor(string memory name, string memory symbol) ERC20(name, symbol) {
```
- Local variable `symbol` shadows:
    - Function `symbol` in `ERC20`
    - Function `symbol` in `IERC20Metadata`

File: ERC20.sol (Line 69, Contract `ERC20`)
```solidity
    function symbol() public view virtual override returns (string memory) {
```

File: IERC20Metadata.sol (Line 21, Contract `IERC20Metadata`)
```solidity
    function symbol() external view returns (string memory);
```



Shadowing Local Variable

The contract has unlocked compiler version. An unlocked compiler version in the source code of the contract permits the user to compile it at or above a particular version. This, in turn, leads to differences in the generated bytecode between compilations due to different compiler versions. This can lead to an ambiguity when debugging as compiler specific bugs may occur in the codebase that would be hard to identify over a span of multiple compiler versions rather than a specific one.

Unlocked Compiler Version

State variables that never change should be declared as `constant` to save gas.

File: GKen.sol (Line 22, Contract `GKen`)
```solidity
    address public PRESALE_ADDRESS = 0x708ef6E756240af2397D5Cecb6C3066DAA67A5d7;
```
- `PRESALE_ADDRESS` should be declared `constant`.


---
File: GKen.sol (Line 23, Contract `GKen`)
```solidity
    address public LP_ADDRESS = 0xc5B2Fc2E11d2008339812f8cE94513f10B4327BC;
```
- `LP_ADDRESS` should be declared `constant`.


---
File: GKen.sol (Line 24, Contract `GKen`)
```solidity
    address public MARKETING_ADDRESS = 0xc450827d10368c2dC0c922deE4A65dBbCD3C4905;
```
- `MARKETING_ADDRESS` should be declared `constant`.


---
File: GKen.sol (Line 25, Contract `GKen`)
```solidity
    address public PARTNERS_ADVISORS_ADDRESS = 0x70d673345DD4Ff8CC8a77d7b77732a7BBC756a21;
```
- `PARTNERS_ADVISORS_ADDRESS` should be declared `constant`.


---
File: GKen.sol (Line 26, Contract `GKen`)
```solidity
    address public DEV_ADDRESS = 0x4A38F7b351B093536c9C527B08fF1d3508C1A76d;
```
- `DEV_ADDRESS` should be declared `constant`.


---
File: GKen.sol (Line 27, Contract `GKen`)
```solidity
    address public PRIVATESALE_ADDRESS = 0xB178dA6F5FBa03732568374f5c1402d4B5E48955;
```
- `PRIVATESALE_ADDRESS` should be declared `constant`.


---
File: GKen.sol (Line 28, Contract `GKen`)
```solidity
    address public REWARD_POOL_ADDRESS = 0xF8848562B41b031E625755455d00CAE3f942c8F5;
```
- `REWARD_POOL_ADDRESS` should be declared `constant`.


---
File: Migrations.sol (Line 5, Contract `Migrations`)
```solidity
    address public owner = msg.sender;
```
- `owner` should be declared `constant`.



State Variable Should Be Declared Constant

All of the `GKen` tokens are sent to seven addresses when deploying the contract. This could be a centralization risk as the owners of the addresses can distribute tokens without obtaining the consensus of the community.

Initial Token Distribution

The contract has one or more payable functions, but does not have a function to withdraw the fund.

File: GKen.sol (Line 117, Contract `GKen`)
```solidity
    receive() external payable {}
```



Locked Ether

According to context, the `if` statement may be redundant since `_fee` should be deducted from `sender`.
``` solidity
   if(recipient == uniswapV2Pair) {                    // distribute sell fee
      super._transfer(sender, TAX_ADDRESS, _fee);
   }else if (sender == uniswapV2Pair) {               // distribute buy fee
      super._transfer(sender, TAX_ADDRESS, _fee);
   }  
```

Unnecessary if Clause

The linked variables assigned in the constructor can be declared as `immutable`. Immutable state variables can be assigned during contract creation but will remain constant throughout the lifetime of a deployed contract. A big advantage of immutable variables is that reading them is significantly cheaper than reading from regular state variables since they will not be stored in storage.

Variables That Could Be Declared as Immutable

Hard Code Address

RobocockUWU

IERC20Metadata.sol

ERC20.sol

GKenERC20.sol

RobocockUWU

Highlights & Alerts

This is just a placeholder

highlight placeholder lorem Ipsum...

highlight lorem

This is a alert demo

Alert demo

Code Audit History

14

0

5

4

5