`public` functions that are never called by the contract could be declared as `external`. `external` functions are more efficient than `public` functions.

Improper Usage of `public` and `external` Type

In the contract `FactoryCreator` the role `_owner` has authority over the `createCardsAndMintTokens()` function shown in the diagram below.
Any compromise to the `_owner` account may allow the hacker to take advantage of this authority to create new cards and mint tokens.
![](https://accelerator-tasks-prod.s3.amazonaws.com/76c142123e8a42abb8f37da345079f0f/diagrams/centralization_FactoryCreator__owner.svg)

Centralization Risks in FactoryCreator.sol

`recoverSigner()` is internal but its name doesn't start with _.

`recoverSigner()` Name Should Start with `_`

The variable `stoppedProductionByScarcityLevel` is declared but not used.

Unused `stoppedProductionByScarcityLevel` Variable

In the contract `YadeckTokens` the role `_owner` has authority over the functions shown in the diagram below.
Any compromise to the `_owner` account may allow the hacker to take advantage of this authority to create a new version of the contract through the function `setNextContract()` set new royalties as well as change URI's.
![](https://accelerator-tasks-prod.s3.amazonaws.com/76c142123e8a42abb8f37da345079f0f/diagrams/centralization_YadeckTokens__owner.svg)

Centralization Risks in YadeckTokens.sol

The `owner()` can set the `feeNumerator` in the contract and there is no upper limit on what the rate can be. In the extreme case, the rate can be as high as 100%, which would imply that users cannot buy or sell the token.

No Upper Limit For Fees

There should always be events emitted in the sensitive functions that are controlled by centralization roles.

Missing Emit Events

The `baseURI()` function is equivalent to the compiler-generated getter function for the `baseURIextended` variable.

User-Defined Getters

The `_setDefaultRoyalty()` function uses the magic number `1000` as default fees in bips.

Yadeck

Highlights & Alerts

This is just a placeholder

highlight placeholder lorem Ipsum...

highlight lorem

This is a alert demo

Alert demo

Code Audit History

9

0

2

0

7